-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React to v19 #1398
Draft
piotrpospiech
wants to merge
7
commits into
update-testing-library
Choose a base branch
from
react-19
base: update-testing-library
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update React to v19 #1398
+1,210
−944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## update-testing-library #1398 +/- ##
==========================================================
- Coverage 95.53% 95.07% -0.46%
==========================================================
Files 175 175
Lines 2867 2865 -2
Branches 773 782 +9
==========================================================
- Hits 2739 2724 -15
- Misses 59 71 +12
- Partials 69 70 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Bridge
Affects some of the bridge packages
Area: Core
Affects the uniforms package
Area: Docs
Affects the documentation or reproductions seed
Area: Theme
Affects some of the theme packages
Bridge: SimpleSchema (v2)
Affects the uniforms-bridge-simple-schema-2 package
Theme: AntD
Affects the uniforms-antd package
Theme: Bootstrap 4
Affects the uniforms-bootstrap4 package
Theme: Bootstrap 5
Affects the uniforms-bootstrap5 package
Theme: MUI
Affects the uniforms-mui package
Theme: Semantic UI
Affects the uniforms-semantic package
Theme: Unstyled
Affects the uniforms-unstyled package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1396
defaultProps
from function components (migration guide)JSX
toReact.JSX
(migration guide)^19.0.0
inpeerDependencies
@types/react
to19.0.10
devDependencies
as pnpm was still using v18cloneElement
Currently, tests are failing with React 19. This requires further investigation.
Important
Failing tests are skipped right now and I added a comment before those tests to make it easier to work with them locally (commit). CI tests are no longer a valid metric.