-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizing window results in huge texture and crash #3200
Comments
Alexander-Wilms
added a commit
to Alexander-Wilms/vcmi
that referenced
this issue
Nov 19, 2023
VCMI created a texture with the height of the original intro video, and the aspect ratio of the actual VCMI window. This resulted in a texture with a width greater than 16384 px. Fixes vcmi#3200
Alexander-Wilms
added a commit
to Alexander-Wilms/vcmi
that referenced
this issue
Jan 28, 2024
VCMI created a texture with the height of the original intro video, and the aspect ratio of the actual VCMI window. This resulted in a texture with a width greater than 16384 px. Fixes vcmi#3200
Alexander-Wilms
added a commit
to Alexander-Wilms/vcmi
that referenced
this issue
Jan 30, 2024
VCMI created a texture with the height of the original intro video, and the aspect ratio of the actual VCMI window. This resulted in a texture with a width greater than 16384 px. Fixes vcmi#3200
Alexander-Wilms
added a commit
to Alexander-Wilms/vcmi
that referenced
this issue
Jan 30, 2024
VCMI created a texture with the height of the original intro video, and the aspect ratio of the actual VCMI window. This resulted in a texture with a width greater than 16384 px. Fixes vcmi#3200
I added some debug output here: https://github.com/vcmi/vcmi/compare/develop...Alexander-Wilms:vcmi:fix-resolution-crash?expand=1 I noticed this output, which seems to be wrong:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When one reduces the height of the VCMI window (it doesn't matter whether this is during the intro or e.g. while viewing the adeventure map), maximizes it and then un-maximizes it, VCMI crashes since it tries to create a huge texture.
Game logs
VCMI_Client_log.txt
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The UI has the aspect ratio of the resolution selected in the launcher and possibly black bars.
Actual behavior
VCMI crashes:
GDB backtrace:
Did it work earlier?
Unknown
Screenshots
![image](https://private-user-images.githubusercontent.com/3226457/284068433-46c45285-7f9f-4de6-82c6-51c084612b79.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5MTA1MzEsIm5iZiI6MTcxOTkxMDIzMSwicGF0aCI6Ii8zMjI2NDU3LzI4NDA2ODQzMy00NmM0NTI4NS03ZjlmLTRkZTYtODJjNi01MWMwODQ2MTJiNzkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDJUMDg1MDMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzE1MDIwNDA1N2Q3ZTdhODZmMTYyM2IzNzk3Y2M5MjgzMjU2NzlmMDM2NGRhMmVjNTQ4NDg5ZDQ3NGQ5YzRiNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.5jgMEXsENWPy4aiabC70fqqgQhdejYhNwgEQ32Vbtt0)
![image](https://private-user-images.githubusercontent.com/3226457/284068496-f01163e8-07ee-4ae6-8fc3-7fb60e4f723c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5MTA1MzEsIm5iZiI6MTcxOTkxMDIzMSwicGF0aCI6Ii8zMjI2NDU3LzI4NDA2ODQ5Ni1mMDExNjNlOC0wN2VlLTRhZTYtOGZjMy03ZmI2MGU0ZjcyM2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDJUMDg1MDMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OGRjY2M3MjM1OTUxOWMwZTM3NDY3MjM0YjQxNzgzYzRkMmYzOWNjNzdjZmIwMDEwZjY5NWFlNWI0NGY5M2JhOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.MXT3V6MtdSLZqY7mNppQCm87okEEliFbyF6XdKwbUPI)
Before maximizing the window:
After un-maximizing the window, just prior to the crash:
Version
Additional context
The issue also affects the changes in #3041
I assume VCMI creates a texture with the height specified in the settings or the intro video, and the aspect ratio of the actual VCMI window. This results in a texture with a width greater than 16384 px.
I added some debug output:
The text was updated successfully, but these errors were encountered: