Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Complete fork? #6

Open
alexgorbatchev opened this issue Jun 7, 2011 · 8 comments
Open

Complete fork? #6

alexgorbatchev opened this issue Jun 7, 2011 · 8 comments

Comments

@alexgorbatchev
Copy link

I'm thinking about making this a full fork. It feels like your features are far ahead of the official lib and they don't seem to be maintaining it. I would really like to convert all names to proper camel casing, it hurts me to see php naming in a js lib :)

what do you think?

@vdepizzol
Copy link
Owner

Hey Alex! I think you are more than welcome to do such proposed changes! I think we can already push changes that won't be compatible with original jquery-tokeninput :).

Thank you!

PS: camel case sounds much better in JS, indeed!

@alexgorbatchev
Copy link
Author

If we do convert to camel, we basically won't be able to merge anything that's forked from the original because diff would be too great :( it would be very painful.

I'm currently trying to figure out what would be nice to merge, before potentially doing this.

@robzolkos
Copy link

+1 great idea

@vdepizzol
Copy link
Owner

Yes, that's true. Specially now that there is some begin of work to make add/remove/clear methods: 7ab7e79

@loopj
Copy link

loopj commented Aug 8, 2011

Hey guys, I've implemented a ton of changes similar to those in this fork in the original version, I'm more than happy to accept pull requests for individual features and bug fixes in the original. Any chance we could sync these versions back up again?

@vdepizzol
Copy link
Owner

Hey, @loopj. I'll be more than happy to sync the versions and request some pulls. I'm travelling right now and will look into this when get back.

@loopj
Copy link

loopj commented Aug 12, 2011

Awesome thanks @vdepizzol let me know if you need any info/assistance.

@ches
Copy link

ches commented Sep 7, 2011

+1 for consolidation efforts :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants