Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using diff tool for rendered doc pages in CI #3434

Open
joelostblom opened this issue Jun 12, 2024 · 6 comments
Open

Consider using diff tool for rendered doc pages in CI #3434

joelostblom opened this issue Jun 12, 2024 · 6 comments

Comments

@joelostblom
Copy link
Contributor

What is your suggestion?

One of my colleagues built a tool that diffs HTML pages in a way that makes it easier to detect changes to the rendered page https://github.com/trevorcampbell/website_diff. Could be a useful tool to add to our CI for doc-related changes.

Have you considered any alternative solutions?

No response

@trevorcampbell
Copy link

Let me know if you folks end up trying it. @briank-git and I would of course be happy to make fixes/improvements to get it working for you if needed.

@joelostblom
Copy link
Contributor Author

Thanks @trevorcampbell and @briank-git! Did you end up making a github actions template somewhere that we could use as a starting point?

@trevorcampbell
Copy link

Ah, right -- that's not done yet but it was on my to-do list at some point. Thanks for the reminder :-) I'll do that in the next few weeks and post here again.

@trevorcampbell
Copy link

Example added here:

https://github.com/trevorcampbell/website_diff/blob/main/.github/workflow-templates/example_workflow.yml

Actual live running example can be found in the deploy_pr_preview.yml in https://github.com/UBC-DSCI/introduction-to-datascience-python/tree/main/.github/workflows .

Example PR with the workflow run on it here: UBC-DSCI/introduction-to-datascience-python#350

Resulting diff site here: https://python.datasciencebook.ca/diff350/index.html

You can see that the diff picks up some unintended changes in the build (that weren't indicated by the source diff).

@joelostblom
Copy link
Contributor Author

Super, thank you @trevorcampbell ! I will look into this over the coming weeks and try to add it.

@trevorcampbell
Copy link

Awesome :-) I'm going to merge that PR in the examples above, so FYI the links to the example PR + diff won't work any more. But the template action will still be in the website_diff repo for you to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants