Windows close doesn't work in electron

[davidanthoff]

I'm running the lyra2019 branch in an electron window and it works great. But if I click on the close button of the electron window, nothing happens, in particular, the window doesn't close.

Does lyra somehow hook into some close event and prevents closing from happening?

[jonathanzong]

here's the problem line -- i recommend commenting it out for now to get your things working, and i think there can be a separate conversation later about whether this is useful for lyra

lyra/src/js/ctrl/listeners.ts

Line 41 in 58b2029

.on('beforeunload', beforeUnload);