Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using goog.url instead of goog.Uri #67

Open
p-himik opened this issue Sep 29, 2020 · 2 comments
Open

Consider using goog.url instead of goog.Uri #67

p-himik opened this issue Sep 29, 2020 · 2 comments

Comments

@p-himik
Copy link

p-himik commented Sep 29, 2020

goog.Uri does not decode values correctly and here google/closure-library#1083 (comment) it was suggested that it's almost certainly better to just use goog.url.
@iku000888
Copy link
Collaborator

@p-himik

Is this related to #66 ?
Either way happy to review a patch!

@p-himik
Copy link
Author

p-himik commented Oct 8, 2020

Related but different. At the very least, I have no idea if goog.url works with data URIs.

Either way, I don't think that goog.url can be used any time soon given that it's a recent addition and CLJS still depends on an older Closure library that doesn't have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p-himik @iku000888