Skip to content

Commit 69a9ad8

Browse files
authored
fix(dashboard): Prevent facet value chip remove button from being hidden on long… (#4712)
1 parent 7f0b651 commit 69a9ad8

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

packages/dashboard/src/lib/components/shared/assigned-facet-values.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export function AssignedFacetValues({
4545
const facetValue = knownFacetValues.find(fv => fv.id === id);
4646
if (!facetValue) return null;
4747
return (
48-
<div className="mb-2 mr-1" key={facetValue.id}>
48+
<div className="mb-2 mr-1 max-w-full" key={facetValue.id}>
4949
<FacetValueChip
5050
facetValue={facetValue}
5151
removable={canUpdate}

packages/dashboard/src/lib/components/shared/facet-value-chip.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,18 @@ export function FacetValueChip({
3636
return (
3737
<Badge
3838
variant="secondary"
39-
className="flex items-center gap-2 py-0.5 pl-2 pr-1 h-6 hover:bg-secondary/80"
39+
className="flex items-center gap-2 py-0.5 pl-2 pr-1 h-6 max-w-full shrink hover:bg-secondary/80"
4040
>
41-
<div className="flex items-center gap-1.5">
42-
<span className="font-medium">{facetValue.name}</span>
41+
<div className="flex items-center gap-1.5 min-w-0 truncate">
42+
<span className="font-medium truncate" title={facetValue.name}>{facetValue.name}</span>
4343
{displayFacetName && (
44-
<span className="text-muted-foreground text-xs">in {facetValue.facet.name}</span>
44+
<span className="text-muted-foreground text-xs truncate" title={facetValue.facet.name}>in {facetValue.facet.name}</span>
4545
)}
4646
</div>
4747
{removable && (
4848
<button
4949
type="button"
50-
className="ml-0.5 inline-flex h-4 w-4 items-center justify-center rounded-full hover:bg-muted/30"
50+
className="ml-0.5 inline-flex h-4 w-4 shrink-0 items-center justify-center rounded-full hover:bg-muted/30"
5151
onClick={() => onRemove?.(facetValue.id)}
5252
aria-label={`Remove ${facetValue.name} from ${facetValue.facet.name}`}
5353
>

0 commit comments

Comments
 (0)