-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link is not saved in NEO field when we use it in child blocks #90
Comments
Seems to be working for me, although can you confirm your |
Yes, in the Longform block we can repeat the Title, Text and Actions blocks. |
What I mean is - they’re the exact same image. Is this correct? I’m pretty sure I understand your setup but I wanted to double check as I can’t replicate this behavior. when you mention is doesn’t save, do any values stay? Do you see the auto save spinner near the entry title as you edit the Neo and Hyper field? |
I'm having the same issues. But I'm starting to suspect this is a Neo thing... Doesn't seem to work for other fields either, such as plain text and asset fields. Vizy also seems to fail to initialize within Neo. 1. Hyper in Neo tests
2. Plain text, asset, Vizy, and Hyper in Neo tests Running all the latest versions:
I'll open an issue at Neo later today and reference this issue. Edit: Opened an issue at Neo - spicywebau/craft-neo#787 |
Confirming this was a Neo bug related to changes in 3.9, fixed now in 3.9.2. |
Hyper still seems to have some issues with the new Neo updates. When you add a block with a Hyper field, the field isn't fully initialised the first time. Refreshing or saving fixes this BUT it will break nested Hyper fields (via slideout). Nested Hyper fields (via slideout) only work if you save again after the initial save (to fix the initialization), and only after each save when adding a new parent link. If you add a new parent link without saving first then adding nested Hyper links will also fail. Also, when adding nested Hyper links (via slideout) and re-opening it without saving the entry, it won't show your nested Hyper links anymore. BUT if you cancel the slideout and then save the entry, the nested Hyper links will have been added. BUT if you would have saved the slideout, with the empty nester Hyper links, and continue to save your page then the nested Hyper links will have been removed (or still empty). I've also tested nested Hyper fields directly in the parent field (not via slideout) and that seems to work fine. I remember that nested Hyper links via slideout has different behaviour from my original nesting issue. Might be related since the new Neo changes? I've recorded a couple of tests: Versions:
|
I'm not sure of the details of what's happened with Neo, but it now no longer loads the It could be down to how we register the JS script with Vite, but it's an asset bundle, so that should be pretty standard. |
The change in Neo causing that is the same as described in verbb/vizy#260 (comment). In this case it means that the registered |
@ttempleton Thanks for that. Yep, I went for a deep-dive into what's going on as |
This is fixed in Neo 3.9.4, read from here on for details: spicywebau/craft-neo#790 (comment) |
Describe the bug
When I try to save a link in a neo-field where the block with the hyper field is assigned as a child block to a neo block, my link is not saved.
This bug also occurs if we specify the setting in the neo block with the hyperfield that the relevant block at the top should not be used.
Steps to reproduce
Craft CMS version
4.5.5
Plugin version
1.1.12
Multi-site?
No
Additional context
The version of Neo was 3.9.0. After downgrading NEO to 3.8.6 I no longer have this problem.
The text was updated successfully, but these errors were encountered: