Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing downloads from private repository #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bugii
Copy link

@bugii bugii commented Dec 6, 2021

Similar to #103 but more minimal and fixes an issue I encountered with anthrax63's solution.

The issue was that according to the GitHub docs (https://docs.github.com/en/rest/reference/repos#get-a-release-asset) there are 2 response types possible:
"To download the asset's binary content, set the Accept header of the request to application/octet-stream. The API will either redirect the client to the location, or stream it directly if possible. API clients should handle both a 200 or 302 response."

If you don't manually handle the 302 response, node-fetch automatically redirects and uses the same HTTP headers as the initial request. Github API then complains that both query params & HTTP header authentication mechanism is present and throws an error. For this reason, 302 redirects are handled manually.

@vercel
Copy link

vercel bot commented Dec 6, 2021

@bugii is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

rastiqdev added a commit to AnimeoTV/hazel that referenced this pull request Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant