Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blob): Provide onUploadProgress({ loaded, total, percentage }) #782

Merged
merged 43 commits into from
Nov 6, 2024
Merged

feat(blob): Provide onUploadProgress({ loaded, total, percentage }) #782

merged 43 commits into from
Nov 6, 2024

Commits on Oct 24, 2024

  1. feat(blob): Provide onUploadProgress({ loaded, total, percentage }) 

    This commit introduces an `onUploadProgress` callback to put/upload*. Since
we're using fetch, this works by making sure every body we send via fetch is a
ReadableStream (web). Once it's a ReadableStream we can follow its consumption.

Caveats:
- This only measures what gets sent to the server, not what was received by the
  server
- Safari & Firefox are not supporting bodies as ReadableStreams, we may need to
  introduce.. xhr!

TODO:
- [] Add XHR fallback for runtimes not supporting streams as bodies but having
  XHR
- [] Add real browser tests ensuring we get multiple onUploadProgress events for
  big files
- [] Ensure we send one event at the start of the upload (progress: 0)
    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d70a84e View commit details
    Browse the repository at this point in the history

  2. update

    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0e11640 View commit details
    Browse the repository at this point in the history

  3. lint

    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    33085b4 View commit details
    Browse the repository at this point in the history

  4. add 0 percent loading before request starts

    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    10efcfa View commit details
    Browse the repository at this point in the history

  5. fix #782 (comment)

    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9a4a7fd View commit details
    Browse the repository at this point in the history

  6. Fix https://github.com/vercel/storage/pull/782\#discussion_r1814659658

    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    59e01f6 View commit details
    Browse the repository at this point in the history

  7. fix https://github.com/vercel/storage/pull/782\#discussion_r1814676109

    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6e6d7b9 View commit details
    Browse the repository at this point in the history

  8. Fix https://github.com/vercel/storage/pull/782\#discussion_r1814676691

    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    57d0270 View commit details
    Browse the repository at this point in the history

  9. Update packages/blob/src/helpers.ts 

    Co-authored-by: Luis Meyer <[email protected]>
    @vvo @luismeyer
    vvo and luismeyer authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4fbdc0e View commit details
    Browse the repository at this point in the history

  10. fix types

    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c69d7e7 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'feat/blob/on-progress' of github.com:vercel/storage int… 

    …o feat/blob/on-progress
    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    808ed45 View commit details
    Browse the repository at this point in the history

  12. move fetch to its own file

    @vvo
    vvo committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7aa175b View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. xhr fallback + refactor

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c8d7567 View commit details
    Browse the repository at this point in the history

  2. Update packages/blob/src/helpers.ts 

    Co-authored-by: Luis Meyer <[email protected]>
    @vvo @luismeyer
    vvo and luismeyer authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    00727af View commit details
    Browse the repository at this point in the history

  3. style

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    45151d9 View commit details
    Browse the repository at this point in the history

  4. fix

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    3ee617d View commit details
    Browse the repository at this point in the history

  5. cosmetic changesgp

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    237165c View commit details
    Browse the repository at this point in the history

  6. add debugging msg

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    703090e View commit details
    Browse the repository at this point in the history

  7. remove

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    84cd3f0 View commit details
    Browse the repository at this point in the history

  8. fix tests

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    248b360 View commit details
    Browse the repository at this point in the history

  9. update multipart

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ba3a851 View commit details
    Browse the repository at this point in the history

  10. fix lint

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    912f988 View commit details
    Browse the repository at this point in the history

  11. make progress events during fetch async

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e64dd26 View commit details
    Browse the repository at this point in the history

  12. add tests, expose event and callback

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2c8e0ba View commit details
    Browse the repository at this point in the history

  13. changeset

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a0c7521 View commit details
    Browse the repository at this point in the history

  14. lint

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5f0ad1c View commit details
    Browse the repository at this point in the history

  15. update

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    3c596cb View commit details
    Browse the repository at this point in the history

  16. update

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9d6ddac View commit details
    Browse the repository at this point in the history

  17. update

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4629f9a View commit details
    Browse the repository at this point in the history

  18. update

    @vvo
    vvo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a74ff98 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. make streams and progress compatible

    @vvo
    vvo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    37e0ae5 View commit details
    Browse the repository at this point in the history

  2. retry on network errors

    @vvo
    vvo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    639a0ac View commit details
    Browse the repository at this point in the history

  3. comments around api code

    @vvo
    vvo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    26462db View commit details
    Browse the repository at this point in the history

  4. CMON js

    @vvo
    vvo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    628929f View commit details
    Browse the repository at this point in the history

  5. C'MON JS

    @vvo
    vvo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    42146d8 View commit details
    Browse the repository at this point in the history

  6. update

    @vvo
    vvo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    aa99c22 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into feat/blob/on-progress

    @vvo
    vvo authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a6fd11f View commit details
    Browse the repository at this point in the history

  8. downgrade undici to allow for old Next.js and Node.js versions

    @vvo
    vvo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5bff1ec View commit details
    Browse the repository at this point in the history

  9. update

    @vvo
    vvo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a28959f View commit details
    Browse the repository at this point in the history

  10. update

    @vvo
    vvo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    aabdf54 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. node 16

    @vvo
    vvo committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    91d0478 View commit details
    Browse the repository at this point in the history

  2. node 16 updates

    @vvo
    vvo committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d24da2e View commit details
    Browse the repository at this point in the history

  3. update

    @vvo
    vvo committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    682d4ba View commit details
    Browse the repository at this point in the history