You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
$ cd packages/bar
$ npx turbo run test
WARNING No locally installed `turbo` found. Using version: 2.0.5.
× missing packageManager field in package.json
It looks like --filter requires the leading ./ as well:
npx turbo run test -F ./packages/bar
• Packages in scope: bar
...
Tasks: 1 successful, 1 total
We do not get a match when omitting ./:
$ npx turbo run test -F packages/bar
× No package found with name 'packages/bar'in workspace
Expected Behavior
I expect filters to match packages/foo regardless of the leading ./ declared in the workspace path, same as npm.
Ideally, ./packages/foo would match both forms. It appears that paths are already normalized (npx turbo run test -F ./packages/../packages/bar locates bar as expected), but don't normalize the leading ./.
chris-olszewski
changed the title
--filterdoes not normalize leading ./ in workspace paths
Package scoping fails when workspace glob has leading ./Jun 25, 2024
Verify canary release
Link to code that reproduces this issue
https://github.com/timostamm/turbotest
What package manager are you using / does the bug impact?
npm
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
v2.0.5 - there's no newer canary
Describe the Bug
In an npm project where workspaces are declared with a leading
./
, Automatic Package Scoping is unable to locate the package.package.json:
It looks like
--filter
requires the leading./
as well:We do not get a match when omitting
./
:Expected Behavior
I expect filters to match
packages/foo
regardless of the leading./
declared in the workspace path, same as npm.Ideally,
./packages/foo
would match both forms. It appears that paths are already normalized (npx turbo run test -F ./packages/../packages/bar
locatesbar
as expected), but don't normalize the leading./
.To Reproduce
See https://github.com/timostamm/turbotest for a minimal reproducible example.
Additional context
Also see discussion #8514
The text was updated successfully, but these errors were encountered: