Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFeat + GIM #56

Open
leleleoo123 opened this issue Aug 29, 2024 · 8 comments
Open

XFeat + GIM #56

leleleoo123 opened this issue Aug 29, 2024 · 8 comments

Comments

@leleleoo123
Copy link

Hi,

Thanks for your amazing work!

Have you noticed the this GIM work: https://xuelunshen.com/gim/ ? It seems using internet videos to train the feature & matching networks is very powerful.

Do you have any plan to retrain the xfeat using their approach?

Best regards.

@Asherchi
Copy link

do you compare the results with GIM and xfeat? which one is better?

@leleleoo123
Copy link
Author

do you compare the results with GIM and xfeat? which one is better?

Only compared them on several image pairs, xfeat can't handle large in-plane rotations while GIM can.

@Asherchi
Copy link

thanks

@Asherchi
Copy link

"We train XFeat in a supervised manner with pixel-level ground truth correspondences", this is from the paper, do you konw how to get the ground truth, and there is no GT from coco datasets.

@guipotje
Copy link
Collaborator

Hi @leleleoo123 @Asherchi, thanks for the suggestion! This method looks interesting and could potentially improve XFeat in specific domain targets, especially since it appears you can extract supervision from raw videos without needing to run expensive SfM pipelines. While I do not plan to retrain XFeat using their approach at the moment, any efforts from others would be greatly appreciated!

However, for large rotations, GIM seem to be learning rotation invariance through brute force, which I wouldn't recommend. I suggest considering a more elegant approach by @georg-bn; please check this issue where he integrates steerers with XFeat.

@Asherchi
Copy link

Asherchi commented Sep 3, 2024

"We train XFeat in a supervised manner with pixel-level ground truth correspondences", this is from the paper, do you konw how to get the ground truth, and there is no GT from coco datasets.

solved, the original code is clear.

@noone-code
Copy link

@Asherchi

Mismatched: Evaluating the Limits of Image Matching Approaches and Benchmarks

image

@Asherchi
Copy link

Asherchi commented Sep 5, 2024

got it, tks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants