Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache option doesn't appear to do anything #125

Open
jmacarthur opened this issue Jul 7, 2016 · 1 comment
Open

Cache option doesn't appear to do anything #125

jmacarthur opened this issue Jul 7, 2016 · 1 comment

Comments

@jmacarthur
Copy link

I tried turning options.CACHE on, but it didn't appear to have any effect. I dug into cachecontrol, and from what I can tell, it won't cache anything unless the response has a Cache-Control header and either a nonzero max-age or an "Expires" header. neo4j (3.0.1) doesn't send either of these, so I don't think it will ever cache a response.

I can't think of any way to fix this in this project, so I've modified my copy of cachecontrol so it caches things without the headers. It might be worth removing the section on caching from the documentation though. If you agree I can submit a PR.

@versae
Copy link
Owner

versae commented Jul 11, 2016

It makes sense. Please, send the PM if you like.

This project has not catch up with the new version of Neo4j 3.x, and unfortunately I am not sure if it will ever do.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants