Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manila CSI #79

Closed
mnaser opened this issue Mar 28, 2023 · 6 comments · Fixed by #80 · May be fixed by #111
Closed

Add Manila CSI #79

mnaser opened this issue Mar 28, 2023 · 6 comments · Fixed by #80 · May be fixed by #111
Assignees

Comments

@mnaser
Copy link
Member

mnaser commented Mar 28, 2023

We should detect what services are running in the cloud (such as Manila or Cinder) and then install the appropriate CSI.

We already deploy Cinder but all the time, instead, we should deploy it if we detect the Cinder service, and the same goes for Manila, that way we finally have ReadWriteMany volumes! :)

@mnaser mnaser linked a pull request May 12, 2023 that will close this issue
@mnaser
Copy link
Member Author

mnaser commented May 12, 2023

I think the direction we'll probably go in this is that the user will have to create a StorageClass on their own afterwards pointing at the correct shareNetwork.

@okozachenko1203
Copy link
Member

WIP: #80

@okozachenko1203
Copy link
Member

I think the direction we'll probably go in this is that the user will have to create a StorageClass on their own afterwards pointing at the correct shareNetwork.

@mnaser yeah, surely.
because a share_network is a tenant-defined object and customers can choose on-fly, we cannot detect it programmatically.

How about this? I think we can have one more label manila_shared_network_id, if it is not specified, we will skip creating the default SC(StorageClass) for manila and if it is specified, we will create a default SC using that.
Even if users didn't specify it as coe cluster label, they can create SC themselves after the cluster creation

@mnaser
Copy link
Member Author

mnaser commented May 29, 2023

I like that approach. I think maybe we use the label "manila_csi_share_network_id" ? :)

@okozachenko1203
Copy link
Member

okozachenko1203 commented May 29, 2023

one more thing is shareNetworkID is only mandatory when driver_handles_share_servers=true. if user's cloud didn't enable it, we don't need to require share_network_id to create the RWM storageclass.
So we have to detect/know driver_handles_share_servers value and decide the required params for SC creation.
Or we can just leave this kind of configuration for SC creation to the user instead of such a complex detection?

@okozachenko1203
Copy link
Member

I like that approach. I think maybe we use the label "manila_csi_share_network_id" ? :)

ok

@mnaser mnaser closed this as completed in #80 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants