Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrades): set correct cluster_template_id #349

Merged
merged 14 commits into from
Mar 28, 2024
Merged

fix(upgrades): set correct cluster_template_id #349

merged 14 commits into from
Mar 28, 2024

Conversation

mnaser
Copy link
Member

@mnaser mnaser commented Mar 27, 2024

It seems that fundamentally, we've relied historically on the code of Magnum
doing some form of 'inheritence' of the labels across clusters, however, the
reality is that it just copies everything over everywhere.

In order to make sure follow it, we stop checking parents (aka, check node
group if not found check cluster if not found check cluster template) and
instead rely on the label value directly configured. If the user used
merge labels then their values will be copied in, if they haven't, it will
copy their values in directly.

This fixes upgrades as well by making sure we set the correct cluster
template ID and copy all the labels, the main reason we had this issue
was because Magnum relied on the driver to copy the labels which we did
but we did not update the cluster template. So, cleaned that up and
added unit tests for coverage too.

Closes #317
Closes #325
Closes: #339

  • fix: use labels from cluster directly
  • fix: use labels from node group directly
  • fix(upgrades): update cluster_template_id correctly

@mnaser mnaser enabled auto-merge (squash) March 28, 2024 18:02
@mnaser mnaser disabled auto-merge March 28, 2024 18:02
@mnaser mnaser merged commit 49dc0c9 into main Mar 28, 2024
13 of 15 checks passed
@mnaser mnaser deleted the upgrade-fixes branch March 28, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants