fix: Improve node group tracking #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mnaser
commented
Jun 11, 2024
mnaser
commented
- Add comments about which functions are sync/async
- Remove extra db request
- Stop waiting for creation of node group
- Remove retries from delete node group
- Switch database state earlier in node group scale
- Refactor node group state tracking
Since the update_nodegroup_status function is called for each node group during updates, it will _not_ find the node group if it hasn't been created yet, and it will keep the status as-is. If it does find it, it will either find it in ScalingUp most likely, which will then make the node group status get 'reset' to CREATE_IN_PROGRESS and no harm done. This eliminates the waiting that happens in the node group creation part of the code.
When deleting a node group, we can simply remove it and update the status of it to DELETE_IN_PROGRESS, from there, the update node group status code will check if it is progressing in the delete or not. It will then clean up after it, so we can make that RPC call take less time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.