Warn when .env keys exist but values are empty

[vidya381]

The current env check only verifies that keys from .env.example are present in .env. It should also warn if a key is present but has no value set.

Return StatusWarn for empty values instead of StatusFail — the key is there but might cause issues at runtime.

Update internal/check/env.go.

[abskptnyk]

hi, can i be assigned to this issue?

[abskptnyk]

hi @vidya381, was there any implementation decision to have parseEnvKeys return map[string]struct{}?

internal/check/env.go:62

func parseEnvKeys(path string) (map[string]struct{}, error) {
	f, err := os.Open(path)
	if err != nil {
		return nil, err
	}
	defer f.Close()

	keys := make(map[string]struct{})
	scanner := bufio.NewScanner(f)
	for scanner.Scan() {
		line := strings.TrimSpace(scanner.Text())
		if line == "" || strings.HasPrefix(line, "#") {
			continue
		}
		key, _, _ := strings.Cut(line, "=")
		key = strings.TrimSpace(key)
		if key != "" {
			keys[key] = struct{}{}
		}
	}
	return keys, scanner.Err()
}

i believe it could have been better, if instead it returned as map[string]string?

[vidya381]

yeah map[string]string makes sense here since we need the values now anyway. go ahead, just make sure the key presence check in EnvCheck.Run still works and update the tests.