Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully separate the core code of miratope #37

Open
2 of 4 tasks
vihdzp opened this issue Jun 18, 2021 · 1 comment
Open
2 of 4 tasks

Fully separate the core code of miratope #37

vihdzp opened this issue Jun 18, 2021 · 1 comment

Comments

@vihdzp
Copy link
Owner

vihdzp commented Jun 18, 2021

Currently, Miratope consists of lots of complex polytope building code, and lots of complex polytope rendering code. We ought to separate these so that the crate is easier to use by others.

Before this separation is fully complete, there's a few things we need to sort out:

  • Verify that the public and private parts of the API make sense.
  • Feature-gate all parts of the code that might not be strictly helpful.
  • Feature-gate the abstract name representations and the language module.
  • Add thorough documentations.
@vihdzp
Copy link
Owner Author

vihdzp commented Jun 28, 2021

Instead of feature-gating the abstract name representation, I just made it separate altogether. Made the code much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant