fix it for interfaces too

Author: kkmuffme

src/Psalm/Internal/Codebase/Populator.php

@@ -603,6 +603,12 @@ private function populateInterfaceData(
                 );
                 $new_parent_interface_storage = $storage_provider->get($new_parent);
             } catch (InvalidArgumentException) {
+                $this->progress->debug('Populator could not find dependency (' . __LINE__ . ")\n");
+
+                $storage->invalid_dependencies[$new_parent] = true;
+
+                $this->invalid_class_storages[$new_parent][] = $storage;
+
                 continue;
             }
 
@@ -686,6 +692,9 @@ private function populateInterfaceDataFromParentInterface(
             $this->progress->debug('Populator could not find dependency (' . __LINE__ . ")\n");
 
             $storage->invalid_dependencies[$parent_interface_lc] = true;
+
+            $this->invalid_class_storages[$parent_interface_lc][] = $storage;
+
             return;
         }
 
@@ -729,6 +738,9 @@ private function populateDataFromImplementedInterface(
             $this->progress->debug('Populator could not find dependency (' . __LINE__ . ")\n");
 
             $storage->invalid_dependencies[$implemented_interface_lc] = true;
+
+            $this->invalid_class_storages[$implemented_interface_lc][] = $storage;
+
             return;
         }
 

tests/StubTest.php

@@ -1202,6 +1202,49 @@ public function run(): float {
         $this->analyzeFile($file_path, new Context());
     }
 
+    public function testUseOnlyStubbedInterface(): void
+    {
+        $this->project_analyzer = $this->getProjectAnalyzerWithConfig(
+            TestConfig::loadFromXML(
+                dirname(__DIR__),
+                '<?xml version="1.0"?>
+                <psalm
+                    errorLevel="1"
+                >
+                    <projectFiles>
+                        <directory name="src" />
+                    </projectFiles>
+
+                    <stubs>
+                        <file name="tests/fixtures/stubs/interface.phpstub" />
+                    </stubs>
+                </psalm>',
+            ),
+        );
+
+        $file_path = (string) getcwd() . '/src/somefile.php';
+
+        $this->addFile(
+            $file_path,
+            '<?php
+                namespace Foo;
+
+                class A implements StubbedInterface {
+                    /**
+                     * @param int $x
+                     */
+                    public function run_stubbed($x): float {
+                        return $x . "";
+                    }
+                }',
+        );
+
+        $this->expectExceptionMessage('InvalidReturnType');
+        $this->expectException(CodeException::class);
+
+        $this->analyzeFile($file_path, new Context());
+    }
+
     public function testStubFileWithExtendedStubbedClass(): void
     {
         $this->project_analyzer = $this->getProjectAnalyzerWithConfig(

tests/fixtures/stubs/interface.phpstub

@@ -0,0 +1,10 @@
+<?php
+namespace Foo;
+
+interface StubbedInterface
+{
+    /**
+     * @param int $x
+     */
+    public function run_stubbed($x): float;
+}