Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted CSS #16

Open
ehannes opened this issue Nov 13, 2014 · 4 comments
Open

Unwanted CSS #16

ehannes opened this issue Nov 13, 2014 · 4 comments

Comments

@ehannes
Copy link
Contributor

ehannes commented Nov 13, 2014

Can you somehow choose not to use the included style.css, without forking this repository and remove it? This file has rules that I do not want in my application, for example rules for body and h1 tags.

@ehannes
Copy link
Contributor Author

ehannes commented Nov 24, 2014

I forked the project and made some css cleaning. The style.css file in the engine included styles for the body and h1 tags. I think that should be up to the user of the engine to decide how to style his body and h1 tags. The updates is available https://github.com/ehannes/fullcalendar-rails-engine/tree/cssCleaning. I can do a pull request if you want to.

@tomatoturnip
Copy link

@ehannes I'm trying to customize this rails engine by adding a few attributes to the event model. Not sure how to get rake db:migrate to work on a rails engine. Any ideas?

@ehannes
Copy link
Contributor Author

ehannes commented Dec 5, 2014

I think your question may be out of topic. I'll send you an email instead and we can continue the conversation there instead, ok?

@kuldeepaggarwal
Copy link
Contributor

@ehannes Yeah go ahead and raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants