Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places thumbnail and images: ratio and file size #86

Closed
AleziaKurdis opened this issue Apr 20, 2021 · 2 comments
Closed

Places thumbnail and images: ratio and file size #86

AleziaKurdis opened this issue Apr 20, 2021 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@AleziaKurdis
Copy link

AleziaKurdis commented Apr 20, 2021

In order to build any explore app from the place API (GET api/v1/places)

RATIO:
It would be a good thing to indicate which ratio the images need to be.
It's better if all users are invited to add pictures with the same standard. The eventual applications that will use those pictures will definitely need a consistent format. If people know before, they might not get the surprise to see their picture completely stretched in any application using them.

I would suggest the 16:9 format since it's the standard of a majority of monitors and official media.

We basically just need to indicate the recommended ratio in the UI where we can enter pictures in the dashboard. No need of any file validation for that. It will be the responsibility of the user to stick with the standard that will be indicated to get good results for the place or profile. (But they do need to know what is the standard)

FILE SIZE:
It would be good to have a file size check when we save any new picture URL in the dashboard (and in the different API).
because someone could put a very fat picture file that can cause serious performance issues in the different applications using those API. (I don't know if such mechanism is already in the system or not, I prefer to mention it if it's not the case)

@Misterblue Misterblue added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 13, 2021
@Misterblue
Copy link
Collaborator

The metaverse-server only saves the URL of the thumbnails and images and thus never sees the actual image (its size or its ratio). These changes need to go into the Dashboard.

@AleziaKurdis
Copy link
Author

Open an issue on the vircadia / project-iamus-dashboard
vircadia/vircadia-metaverse-dashboard#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants