Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate segfault #87

Closed
wants to merge 9 commits into from
Closed

Investigate segfault #87

wants to merge 9 commits into from

Conversation

virgesmith
Copy link
Owner

@virgesmith virgesmith commented Jul 27, 2024

trying to track down cause of segfault in win tests... (worked 29/6, failed 6/7)
pybind11 2.13 was released 26/6

Using asan it seems that all C++ exceptions thrown in neworder have some address violation associated with them, and this is not a recent change in pybind11.

(add extra_compile_args=["-fsanitize=address" ], run with e.g. LD_PRELOAD=$(gcc --print-file-name=libasan.so) python umr.py)

@virgesmith virgesmith changed the title revert pybind11 Investigate segfault Jul 27, 2024
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.04%. Comparing base (396c162) to head (7b9c8e5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   92.48%   93.04%   +0.55%     
==========================================
  Files          16       14       -2     
  Lines         679      719      +40     
==========================================
+ Hits          628      669      +41     
+ Misses         51       50       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virgesmith
Copy link
Owner Author

failure disappeared resolved itself in Aug. assuming compiler bug that was fixed

@virgesmith virgesmith closed this Oct 22, 2024
@virgesmith virgesmith deleted the segfault branch October 22, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant