Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug when user has been created with dummy email #3

Open
rafaltrojanowski opened this issue Jun 23, 2018 · 0 comments
Open

bug when user has been created with dummy email #3

rafaltrojanowski opened this issue Jun 23, 2018 · 0 comments

Comments

@rafaltrojanowski
Copy link

rafaltrojanowski commented Jun 23, 2018

Some providers does not return email.

To fix this issue I'd suggest to change:

existing_user = User.where('email = ?', auth_params['info']['email']).try(:first) 

to

existing_user = authentication&.user

Otherwise create_authentication_and_sign_in and sign_in_and_redirect(:user, user)
when user is nil would throw an error.

If you agree with me please fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant