Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still writes to /etc/resolv.conf , causes docker test build to fail. #69

Closed
chris001 opened this issue May 21, 2022 · 4 comments
Closed

Comments

@chris001
Copy link
Contributor

chris001 commented May 21, 2022

Found another line in the install process (last one, looks like) trying to write to /etc/resolv.conf during the install.
Causes my docker test build to fail.
Here.
It's during Phase 3: Configuration, 6/18 Configuring Net.
Error: Failed to replace /etc/resolv.conf with /etc/resolv.conf.webmintmp.3051 : Device or resource busy

Need fix to get #61 and #35 working.

@swelljoe
Copy link
Collaborator

I've already told you this is removed, the new version just hasn't been pushed yet. You can see the change in the Virtualmin-Config repo. I'm not going to argue about it.

@chris001
Copy link
Contributor Author

You can see the change in the Virtualmin-Config repo.

I searched that repo, and couldn't find a branch with the /etc/resolv.conf removed from Net.pm.
Kindly share a link to Net.pm in the Virtualmin-Config repo with /etc/resolv.conf removed?

@iliajie
Copy link
Contributor

iliajie commented May 22, 2022

It's in my latest PR that hasn't been merged yet.

@swelljoe
Copy link
Collaborator

Net does not run at all anymore in the next version (all Net.pm does is modify resolv.conf in a variety of ways). The necessary change is not in Ilia's PR. It is in a recent PR I made. Jebus. I'm not lying to you. It'll be gone when I roll an update.

Can we stop arguing about this?

@virtualmin virtualmin locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants