Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questioning default attribute of new listen directive in module version 2.22 #20

Open
neosonic2 opened this issue Apr 9, 2021 · 3 comments

Comments

@neosonic2
Copy link

Hello,

We are using the neW Nginx module version 2.22 in our Virtualmin Professional 6.16 setup and are enjoying the features added to support HTTP/2, correct HTTP 301 redirects, and excluding IP addresses from listen directives. However, it is this last feature that I am concerned about.

When this option is activated, it creates HTTPS listen directives that look like this: listen 443 default ssl http2;

Will the default attribute in this directive create conflicts if we have multiple Nginx virtual hosts? I thought it was better to specify one default server? Is there a way to tell Virtualmin not to include the default attribute when creating a new virtual server?

Thanks for any insight provided.

@neosonic2 neosonic2 changed the title Question default attribute of new listen directive in module version 2.22 Questioning default attribute of new listen directive in module version 2.22 Apr 9, 2021
@jcameron
Copy link
Collaborator

The default attribute is only used when a domain has it's own private IP address - so there shouldn't be any conflict with other domains.

@neosonic2
Copy link
Author

Our server running Virtualmin only has 1 public IP address (and 1 private LAN-only IP address). Does Virtualmin perform any validation when determining whether to add the default attribute to an Nginx virtual host configuration?

@jcameron
Copy link
Collaborator

Virtualmin should only use default for the first SSL website on an IP. Subsequent ones won't get it.

Are you seeing any specific problems due to this directive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants