Feb '25 Updates to Element View UX #495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #489
Closes #484
Closes #485
Closes #487
Closes #464
Closes #449
Give a longer description of what this PR addresses and why it's needed
Copilot auto-generated summary
This pull request includes changes to improve the user interface and functionality of the
ElementViewcomponent, specifically focusing on theAltTextSidebar,AddPlot, andSidebarcomponents. The most important changes include updating the titles and headings, modifying the histogram plotting functionality, and enhancing the sidebar layout.Improvements to titles and headings:
packages/upset/src/components/AltTextSidebar.tsx: Updated the title and removed redundantUpsetHeadingelements. [1] [2]packages/upset/src/components/ElementView/ElementSidebar.tsx: Added a title to the sidebar and replacedUpsetHeadingelements with a new title format. [1] [2]packages/upset/src/components/ProvenanceVis.tsx: Added a title to the history sidebar and removed theUpsetHeadingelement.Modifications to histogram plotting:
packages/upset/src/components/ElementView/AddPlot.tsx: Replaced thefrequencyprop withdensityfor histogram plots and updated the related logic. [1] [2] [3] [4] [5] [6] [7] [8]packages/upset/src/components/ElementView/generatePlotSpec.ts: Updated the histogram spec generation functions to usedensityinstead offrequency. [1] [2]Enhancements to sidebar layout:
packages/upset/src/components/custom/Sidebar.tsx: Added a title prop to the sidebar component and adjusted the layout to include the title at the top. [1] [2] [3] [4]packages/upset/src/components/ElementView/BookmarkChips.tsx: Simplified the layout by removing unnecessaryuseMemousage.Other changes:
packages/upset/src/components/ElementView/AddPlotDialog.tsx: Added a new tab for KDE plots in theAddPlotDialogcomponent. [1] [2]packages/upset/src/components/ElementView/ElementTable.tsx: Refactored the column generation logic to include display names and types. [1] [2]packages/upset/src/components/ElementView/ElementVisualization.tsx: Added a key prop to the plotBoxcomponent to ensure unique identification.