Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default values for the plot information text #393

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

NateLanza
Copy link
Contributor

Does this PR close any open issues?

No

Give a longer description of what this PR addresses and why it's needed

Updates the default plot information text to be more comprehensible.

Provide pictures/videos of the behavior before and after these changes (optional)

Before:
image
After:
Screenshot 2024-09-04 at 2 39 59 PM

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

No

@NateLanza NateLanza requested a review from JakeWags September 4, 2024 20:42
@NateLanza NateLanza self-assigned this Sep 4, 2024
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit 32d9256
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/66d8c61fa20da000086b884a
😎 Deploy Preview https://deploy-preview-393--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@NateLanza NateLanza merged commit 11fb38b into main Sep 4, 2024
7 checks passed
@NateLanza NateLanza deleted the plotinfo-default-fix branch September 4, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants