Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only generate alttext if sidebar is open #395

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

NateLanza
Copy link
Contributor

Does this PR close any open issues?

Closes #353

Give a longer description of what this PR addresses and why it's needed

Minor optimization: only generates the alttext if the Text Descriptions sidebar is open.

Provide pictures/videos of the behavior before and after these changes (optional)

No visible change in behavior.

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • ...

@NateLanza NateLanza requested a review from JackWilb September 24, 2024 21:29
@NateLanza NateLanza self-assigned this Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit af1f8a7
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/66f32f5725369b0008608157
😎 Deploy Preview https://deploy-preview-395--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NateLanza NateLanza merged commit 9d1fca8 into main Sep 27, 2024
7 checks passed
@NateLanza NateLanza deleted the 353-alttext-optimization branch September 27, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization: Only generate alt-txt when side panel is open
2 participants