In-plot bookmarking #416
Merged
In-plot bookmarking #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NateLanza
approved these changes
Nov 4, 2024
NateLanza
requested changes
Nov 4, 2024
@NateLanza Forgot to comment it here, but Jack and I talked about this and I was planning to fix it. Also found a bug where bookmarking through the plot uses the internal id rather than the proper display name. I'll let you know when those are ready |
NateLanza
approved these changes
Nov 7, 2024
| * @param row - The row for which the color is being selected. | ||
| * @returns The color associated with the given row. | ||
| */ | ||
| export const BookmarkedColorSelector = selectorFamily<string, Row>({ |
There was a problem hiding this comment.
First char of name should be lowercase?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #360
Give a longer description of what this PR addresses and why it's needed
This PR adds the ability for the user to click the bookmark star in the plot to bookmark the subset or aggregate row.
Provide pictures/videos of the behavior before and after these changes (optional)
Screen.Recording.2024-10-31.at.10.55.08.AM.mov
Have you added or updated relevant tests?
Have you added or updated relevant documentation?
Are there any additional TODOs before this PR is ready to go?
None