Default to viewing all elements instead of none when no selection is active #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2024 02:39
…o bookmarked or selected intersections) return all items instead of none
…intersection selection
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JakeWags
approved these changes
Nov 7, 2024
NateLanza
force-pushed
the
398-view-all-elements
branch
from
8af8351 to
0a09836
Compare
@JakeWags I looked into this; I think having nothing visualized in the chart looks bad, and since there's no point having nothing in the visualization if a 0-element intersection is selected, I'm leaving the behavior as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #398
Give a longer description of what this PR addresses and why it's needed
Previously, having no active row selection would result in no elements being shown in element view. Now, no row selection results in all elements being shown, so that both row & element selections act as filters on the set of all elements. As a result of this, element selections can now be made without any row selection; this filter is applied to all elements.
Provide pictures/videos of the behavior before and after these changes (optional)
Before:
After:
Have you added or updated relevant tests?
Have you added or updated relevant documentation?