Don't make setsockopt call if option is false

hmahmood · vishvananda · commit 5e915e014938 · 2022-04-04T10:29:18.000-05:00
diff --git a/nl/nl_linux.go b/nl/nl_linux.go
@@ -504,8 +504,10 @@ func (req *NetlinkRequest) Execute(sockType int, resType uint16) ([][]byte, erro
 		if err := s.SetReceiveTimeout(&SocketTimeoutTv); err != nil {
 			return nil, err
 		}
-		if err := s.SetExtAck(EnableErrorMessageReporting); err != nil {
-			return nil, err
+		if EnableErrorMessageReporting {
+			if err := s.SetExtAck(true); err != nil {
+				return nil, err
+			}
 		}
 
 		defer s.Close()

Original file line number	Diff line number	Diff line change
`@@ -504,8 +504,10 @@ func (req *NetlinkRequest) Execute(sockType int, resType uint16) ([][]byte, erro`
`504`	`504`	`if err := s.SetReceiveTimeout(&SocketTimeoutTv); err != nil {`
`505`	`505`	`return nil, err`
`506`	`506`	`}`
`507`		`- if err := s.SetExtAck(EnableErrorMessageReporting); err != nil {`
`508`		`- return nil, err`
	`507`	`+ if EnableErrorMessageReporting {`
	`508`	`+ if err := s.SetExtAck(true); err != nil {`
	`509`	`+ return nil, err`
	`510`	`+ }`
`509`	`511`	`}`
`510`	`512`
`511`	`513`	`defer s.Close()`