bv_* with prebuilt files

[markcmiller86]

Date: Wed, 07 Apr 2021 14:24:58 -0700
From: allen at sci.utah.edu (Allen Sanderson)
This post was imported from the [email protected] email archive

---

Hello,

I am wondering if within the bv_* modules we have any standard when instead of a tarball of source
code the tarball is binary files and the bv_* just does a copy instead of a build then copy to the
thirdparty install dir

The specific question is in general the directory with the source code is build directory so there
is a variable MYLIB_BUILD_DIR. Now when there is no building it is not really a build dir and I
noticed that for a few bv_* files (tbb, embree, ispc) MYLIB_INSTALL_DIR_NAME was used instead.

The problem with that variable name is there is already MYLIB_INSTALL_DIR which is the destination
(e.g. the thirdparty install dir). So it is confusing.

For the present time and for consistency I nuked that and just went with MYLIB_BUILD_DIR even though
there is no building. However, I can see going forward we might have more bv_* with prebuilt libs.
And now that we are doing more out of source builds we might want to have the following:

MYLIB_SRC_DIR - source code from a tarball
MYLIB_BUILD_DIR - could the the source code dir or an out of source dir
MYLIB_BINARY_DIR - binary code from a tarball
MYLIB_INSTALL_DIR -  the thirdparty install dir for this lib.

Hopefully the above makes sense.

Cheers,

Allen

Allen Sanderson
SCI Institute
University of Utah

URL: <https://elist.ornl.gov/mailman/private/visit-
developers/attachments/20210407/fc18f69f/attachment.htm>

---

[markcmiller86]

Date: Wed, 07 Apr 2021 14:35:06 -0700
From: brugger1 at llnl.gov (Brugger, Eric)
This post was imported from the [email protected] email archive

---

Hi Allen,

Your proposed names make sense. Can you submit an issue for it.

Eric

From: Allen Sanderson via visit-developers <visit-developers at elist.ornl.gov>
Sent: Wednesday, April 7, 2021 2:25 PM
To: VisIt Developers <visit-developers at elist.ornl.gov>
Cc: Sanderson, Allen Reed <sanderson5 at llnl.gov>
Subject: [visit-developers] [EXTERNAL] bv_* with prebuilt files

Hello,

I am wondering if within the bv_* modules we have any standard when instead of a tarball of source
code the tarball is binary files and the bv_* just does a copy instead of a build then copy to the
thirdparty install dir

The specific question is in general the directory with the source code is build directory so there
is a variable MYLIB_BUILD_DIR. Now when there is no building it is not really a build dir and I
noticed that for a few bv_* files (tbb, embree, ispc) MYLIB_INSTALL_DIR_NAME was used instead.

The problem with that variable name is there is already MYLIB_INSTALL_DIR which is the destination
(e.g. the thirdparty install dir). So it is confusing.

For the present time and for consistency I nuked that and just went with MYLIB_BUILD_DIR even though
there is no building. However, I can see going forward we might have more bv_* with prebuilt libs.
And now that we are doing more out of source builds we might want to have the following:

MYLIB_SRC_DIR - source code from a tarball
MYLIB_BUILD_DIR - could the the source code dir or an out of source dir
MYLIB_BINARY_DIR - binary code from a tarball
MYLIB_INSTALL_DIR -  the thirdparty install dir for this lib.

Hopefully the above makes sense.

Cheers,

Allen

Allen Sanderson
SCI Institute
University of Utah

URL: <https://elist.ornl.gov/mailman/private/visit-
developers/attachments/20210407/56007e65/attachment.htm>

---

[markcmiller86]

Date: Mon, 12 Apr 2021 09:21:01 -0700
From: allen at sci.utah.edu (Allen Sanderson)
This post was imported from the [email protected] email archive

---

Hi Eric,

Done.

https://github.com/visit-dav/visit/issues/5617 <https://github.com/visit-dav/visit/issues/5617>

Cheers,

Allen

> On Apr 7, 2021, at 3:35 PM, Brugger, Eric <brugger1 at llnl.gov> wrote:
>
> Hi Allen,
>
> Your proposed names make sense. Can you submit an issue for it.
>
> Eric
>
> From: Allen Sanderson via visit-developers <visit-developers at elist.ornl.gov>
> Sent: Wednesday, April 7, 2021 2:25 PM
> To: VisIt Developers <visit-developers at elist.ornl.gov>
> Cc: Sanderson, Allen Reed <sanderson5 at llnl.gov>
> Subject: [visit-developers] [EXTERNAL] bv_* with prebuilt files
>
> Hello,
>
> I am wondering if within the bv_* modules we have any standard when instead of a tarball of source
code the tarball is binary files and the bv_* just does a copy instead of a build then copy to the
thirdparty install dir
>
> The specific question is in general the directory with the source code is build directory so there
is a variable MYLIB_BUILD_DIR. Now when there is no building it is not really a build dir and I
noticed that for a few bv_* files (tbb, embree, ispc) MYLIB_INSTALL_DIR_NAME was used instead.
>
> The problem with that variable name is there is already MYLIB_INSTALL_DIR which is the destination
(e.g. the thirdparty install dir). So it is confusing.
>
> For the present time and for consistency I nuked that and just went with MYLIB_BUILD_DIR even
though there is no building. However, I can see going forward we might have more bv_* with prebuilt
libs. And now that we are doing more out of source builds we might want to have the following:
>
> MYLIB_SRC_DIR - source code from a tarball
> MYLIB_BUILD_DIR - could the the source code dir or an out of source dir
> MYLIB_BINARY_DIR - binary code from a tarball
> MYLIB_INSTALL_DIR -  the thirdparty install dir for this lib.
>
> Hopefully the above makes sense.
>
> Cheers,
>
> Allen
>
>
> Allen Sanderson
> SCI Institute
> University of Utah
>
>
>
>
> <winmail.dat>

URL: <https://elist.ornl.gov/mailman/private/visit-
developers/attachments/20210412/a74d43da/attachment.htm>

---