Small test suite improvement

[markcmiller86]

I am adding more tests to the (102 cases) in the silo.py file. I probably should create a new .py file but this doing more testing of Silo data types and it seemed to fit there. That aside, I've identified a nice little improvement to the test suite but I think I am also missing an OO Python (hint @cyrush) piece of the solution. Here are the key things this little improvement aims to do...

• Facilitate the @biagas test pattern of adding new python functions for a class of test in a .py file
• Automating the calls to TestSection() based on either the function's name (bullet above) or its """doc string"""
• Re-initializing a counter for all the tests associated with this function
• Auto-naming each file emitted by calls to Test(), TestText() etc. based on the python filename and the function name.
• Opens the database associated with this block of tests (if more than one db is used in the block more design though is required)
• Closes databases when done using them
• Calls DeleteAllPlots(), ResetView() and the block of tests is complete.

Here is a (procedural python) approach I've got working (mostly) below for some of the above. Note the new method TestAutoName() which does what Test() does but creates the name of the test automatically and adds TestSection()

import os, inspect

caseIndex = 0

#
# Here is the magic method that names the test and gives it a sequence number
#
def TestAutoName():

    global caseIndex

    callingFileName = inspect.stack()[1].filename
    callingFuncName = inspect.stack()[1].function
    callingFunc = globals()[callingFuncName]
    if hasattr(callingFunc, '__doc__'):
        callingFuncDoc = getattr(callingFunc, '__doc__')
    else:
        callingFuncDoc = callingFuncName

    if caseIndex == 0:
        TestSection(callingFuncDoc)

    testName = os.path.splitext(os.path.basename(callingFileName))[0] + '_' + callingFuncName

    Test("%s_%d"%(testName, caseIndex))

    caseIndex += 1

def curvilinear_3d_surface():
    """Curvilinear (quad) surfaces in 3D"""

    caseIndex = 0
    OpenDatabase(silo_data_path("quad_disk.silo"))

    AddPlot("Pseudocolor","sphElev_on_mesh_3d")
    ResetView()
    DrawPlots()
    TestAutoName()
    DeleteAllPlots()

    AddPlot("Pseudocolor","sphElev_on_meshD_3d")
    DrawPlots()
    TestAutoName()
    DeleteAllPlots()

    CloseDatabase(silo_data_path("quad_disk.silo"))
    OpenDatabase(silo_data_path("specmix_quad.silo"))

curvilinear_3d_surface()

Here is what it produced for my case. Incompleted stuff here includes having to remember to set caseIndex = 0 in the function. Having to open and close databases, etc. But, I hope others can see where I am headed.

It produced these test names...

[markcmiller86]

So, I added this enhancement in

visit/src/test/visit_test_main.py

Lines 1030 to 1045 in 69c8862

	def TestAutoName():
	# Static local vars holding values from previous use
	if not hasattr(TestAutoName, '_autoNamePrefix'):
	TestAutoName._autoNamePrefix = ''
	TestAutoName._autoNameIndex = 0
	callingFileName = inspect.stack()[1].filename
	callingFuncName = inspect.stack()[1].function
	callingFunc = globals()[callingFuncName]
	if hasattr(callingFunc, '__doc__'):
	callingFuncDoc = getattr(callingFunc, '__doc__')
	else:
	callingFuncDoc = callingFuncName
	testNamePrefix = os.path.splitext(os.path.basename(callingFileName))[0] + '_' + callingFuncName

It seems pretty handy. Curious what others think.

[brugger1]

That functionality looks super cool! It produces good names and its easy to use. BTW, that's some pretty cool Python coding to get the file and function name! I didn't know that was possible.

[markcmiller86]

You can do anything with Python if you do enough google searches and stackoverflow reads 😆

[markcmiller86]

You can do anything with Python if you do enough google searches and stackoverflow reads 😆

But, I still believe its possible to do more with Perl 🤣