Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt open pull-requests from almende/vis is usefull #43

Open
7 of 29 tasks
mojoaxel opened this issue Jul 29, 2019 · 13 comments
Open
7 of 29 tasks

adopt open pull-requests from almende/vis is usefull #43

mojoaxel opened this issue Jul 29, 2019 · 13 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mojoaxel
Copy link
Member

mojoaxel commented Jul 29, 2019 •
edited by Thomaash
Loading

Lets together go through all oben pull request for almende/vis and see what we can selvage 😉
@mojoaxel mojoaxel added enhancement New feature or request help wanted Extra attention is needed labels Jul 29, 2019
@mojoaxel
Copy link
Member Author

mojoaxel commented Jul 29, 2019 •
edited
Loading

almende/vis#3846

❓ Looks simple. Adds multible functions to the Network prototype. Not sure why we need this.

@mojoaxel
Copy link
Member Author

almende/vis#3856

👍 This looks like a useful fix.

@mojoaxel
Copy link
Member Author

almende/vis#3880

❗ 👍 Looks useful, but is missing documentation :-(

@mojoaxel
Copy link
Member Author

almende/vis#3881

👍 Looks like everything is there. Could be useful to somebody! Maybe needs a test.

@mojoaxel
Copy link
Member Author

almende/vis#4070

👍 🚀 This is just an example, but a useful one! We definitely should adopt this!

@mojoaxel
Copy link
Member Author

almende/vis#4159

👍 Nice speed improvement. Needs only minor adoption.

@mojoaxel
Copy link
Member Author

almende/vis#4172

👍 Nice new set of images. This would be an improvement, but I think the best way would be to replace these images all together (see #31)

@mojoaxel mojoaxel added the good first issue Good for newcomers label Jul 29, 2019
@mojoaxel
Copy link
Member Author

almende/vis#4202

❗ 👍 Look good. Looks like a improvement of the dot language "dir" feature. Docs and an example is missing 😞

@mojoaxel
Copy link
Member Author

almende/vis#4223

👎 No longer needed. Already fixed.

@mojoaxel
Copy link
Member Author

almende/vis#4229

👍 Should be merged!

@mojoaxel
Copy link
Member Author

almende/vis#4242

👍 Should be merged!

@mojoaxel
Copy link
Member Author

almende/vis#4280

👍 looks useful. Should be checked an merged.

@mojoaxel mojoaxel removed the good first issue Good for newcomers label Oct 2, 2019
@kmalyavina
Copy link
Contributor

almende/vis#3846

❓ Looks simple. Adds multible functions to the Network prototype. Not sure why we need this.

Ran into this myself when trying to convert what I was working on (basically the Neighborhood Highlighting example but with clusters) from regular JS to TypeScript.

network.updateClusteredNode() exists in the type definition, compiler is happy, but breaks with TypeError: network.updateClusteredNode is not a function when it tries to execute.

If I try network.clustering.updateClusteredNode(), the compiler complains that Property 'clustering' does not exist on type 'Network'.

@kmalyavina kmalyavina mentioned this issue Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mojoaxel @kmalyavina