Nested groups cannot collapse when groups are plain array #203
Labels
bug
Something isn't working
Comments
|
By the way, this was reported in yotamberk/timeline-plus#113 quite some time ago, with a near identical fiddle. |
strazto
added a commit
to strazto/vis-timeline
that referenced
this issue
Oct 13, 2020
strazto
added a commit
to strazto/vis-timeline
that referenced
this issue
Oct 13, 2020
Squash of following: commit 840ca81 Author: Matthew Strasiotto <[email protected]> Date: Tue Oct 13 20:46:21 2020 +1100 chore(examples.nestedgroups): revert prev This reverts commit 1a8fd7e. Please squash this. commit 1a8fd7e Author: Matthew Strasiotto <[email protected]> Date: Tue Oct 13 20:45:11 2020 +1100 chore(examples.nestedgroups): add example to demonstrate fix of visjs#203 commit 5a64274 Author: Matthew Strasiotto <[email protected]> Date: Tue Oct 13 20:41:51 2020 +1100 fix(timeline.setgroups): nested groups fold correcly when input is array Fixes visjs#113
strazto
added a commit
to strazto/vis-timeline
that referenced
this issue
Oct 24, 2020
yotamberk
added a commit
that referenced
this issue
Oct 24, 2020
…ray (#718) * fix(timeline.setgroups): nested groups fold correcly when input is array Fixes #113 * chore(examples.nestedgroups): add example to demonstrate fix of #203 * chore(examples.nestedgroups): revert prev This reverts commit 1a8fd7e. Please squash this. Co-authored-by: Yotam Berkowitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
new Timeline(...)is given groups with nested groups, the top groups appear with an arrow that switches from down to sideways, indicating the nested groups should disappear. However, if the groups object given is a plain array (rather than aDataSet), they do not disappear.here is a fiddle that demonstrates the broken behavior. I have commented out the workaround -- by using a
DataSet. If you comment out thevar groups = [...assignment and uncomment thevar groups = new DataSet...assignment, it will start working. (Note you can select the block and usectl-/to bulk comment).The text was updated successfully, but these errors were encountered: