Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning, Release, Changelog, Install #6

Open
psteinb opened this issue Feb 8, 2021 · 2 comments
Open

Versioning, Release, Changelog, Install #6

psteinb opened this issue Feb 8, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@psteinb
Copy link
Collaborator

psteinb commented Feb 8, 2021

What?

  • Add a git tag before the hackathon
  • Create a release after the hackathon is done.
  • Make sure that setup.py and installation instructions still work
  • Inquire about continuous integration
  • Properly comment ReversibleGraphNet and Node, it's a recursive nightmare
  • Fix the issue with ReversibleGraphNet._buffers (i.e. edges on the computation graph)
    not freeing once they are no longer needed, and also being included in state_dict()
  • Write some kind of changelog to put in the README, to let people know what has changed

Difficulty? 1/5

@psteinb psteinb added the help wanted Extra attention is needed label Feb 8, 2021
@wapu
Copy link
Collaborator

wapu commented Feb 8, 2021

I moved the commenting and the buffer problem to individual issues to make it easier to assign and track them. The remaining points can all be seen as "github bookkeeping" of sorts.

@ardizzone
Copy link
Member

  • Add a git tag before the hackathon
  • Create a release after the hackathon is done.
  • Make sure that setup.py and installation instructions still work
  • Write some kind of changelog to put in the README, to let people know what has changed

@ardizzone ardizzone changed the title Miscellaneous Versioning, Release, Changelog, Install Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants