What is the extent of Vite's CJS-ESM interoperability?

[silvenon]

Hello, I'm looking at #19036 and wondering if there's anything smaller that I should report, maybe to an upstream project like Rollup, regarding CommonJS interoperability.

For example I noticed that when using ssr.noExternal if a CJS package I installed does the following:

module.exports = {
  foo: require('./foo'),
}

The require() call will remain after vite build, which won't work in an ESM project, but if I move it out of the expression:

const foo = require('./foo')
module.exports = { foo }

the ./foo module will get inlined properly. Is this worth reporting to Rollup maybe?

Also, any usage of __dirname and __filename will remain as-is, they won't get converted to import.meta.dirname and import.meta.filename.

Is there some way to know the exact extent and the limitations of Vite's interoperability with CommonJS?