Broad data uri regex captures wrong ids in resolveId

[jsudelko]

Describe the bug

The data uri regex in

vite/packages/vite/src/node/plugins/dataUri.ts

Line 7 in 95020ab

const dataUriRE = /^([^/]+\/[^;,]+)(;base64)?,([\s\S]*)$/

is too broad. It basically matches anything with a comma...continuing down to new URL('./foo.js?number=1,2,3') which is an invalid url.

Reproduction

https://regex101.com/r/oFvriu/2

Steps to reproduce

I couldn't do get the reproduction immediately trigger the data-uri plugin on vite.new and I'm not able to create a git repro right now. But it's a logic problem that's self-evident from just reading the code and seeing https://regex101.com/r/oFvriu/2.

Let me know if further info is needed.

System Info

not environment specific. logic bug.

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.