sharedDuringBuild: true doesn't work in some cases

[hi-ogawa]

Describe the bug

This is probably an edge case. It looks like sharedDuringBuild: true doesn't function when there are differences in plugin indices since the logic depends on matching plugin.name at the same index:

vite/packages/vite/src/node/build.ts

Lines 1578 to 1591 in 95020ab

	for (let i = 0; i < environmentPlugins.length; i++) {
	const environmentPlugin = environmentPlugins[i]
	const sharedPlugin = config.plugins[i]
	if (
	config.builder.sharedPlugins ||
	environmentPlugin.sharedDuringBuild
	) {
	if (environmentPlugin.name !== sharedPlugin.name) {
	validMixedPlugins = false
	break
	}
	environmentPlugins[i] = sharedPlugin
	}
	}

For example, this can happen when a custom environment has build.modulePreload: false as it offsets plugin list by:

vite/packages/vite/src/node/plugins/index.ts

Lines 58 to 60 in 95020ab

	modulePreload !== false && modulePreload.polyfill
	? modulePreloadPolyfillPlugin(config)
	: null,

I think most of the case explicitly setting modulePreload: false isn't necessary, but this kind of pattern exists in other places?

Reproduction

https://github.com/hi-ogawa/reproductions/tree/main/vite-environment-sharedDuringBuild

Steps to reproduce

• open https://stackblitz.com/github/hi-ogawa/reproductions/tree/main/vite-environment-sharedDuringBuild?file=vite.config.ts
• run pnpm build

This reproduction initializes sharedValue in a config file, which is then accessed inside a plugin hook. Adding a console.log, it shows something like this:

// during config loading
[in config loading] { sharedValue: '0agdwk0hf1a' }
[in config loading] { sharedValue: 'el3nuodbd05' }
[in config loading] { sharedValue: 't0dzs2llqoh' }

// during client build
[in plugin.writeBundle] { sharedValue: '0agdwk0hf1a' }

// during worker build
[in plugin.writeBundle] { sharedValue: 't0dzs2llqoh' }   // <--- this should match the first one 0agdwk0hf1a

System Info

(stackblitz) 

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    vite: 6.0.0-beta.1 => 6.0.0-beta.1

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.