-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make it easier to configure environment runner #18273
fix: make it easier to configure environment runner #18273
Conversation
|
Won't this make it impossible to swap the ModuleRunner while keeping |
What do you mean by "swap"? It always requires the
This PR just hides the complexity of calling the Basically, what I am saying is that |
I mean using a custom ModuleRunner that extends the ModuleRunner class. I guess it's allowed to be used like that, reading this comment.
I think this PR makes it more easier and that is good, but I guess we need to give a way to declare a |
I see what you mean now. I will revert the |
Description
Hide the complexity of the custom runner configuration. If you need to configure the runner, you will most likely use the
createServerModuleRunner
. It just has a single option argument, let's pass it down directly instead of requiring the user to import the function - they shouldn't even need to know it exists.