-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSR Page Reload does not refresh page on the client after upgrading to Vite 6 #19114
Comments
This is a known breaking change and the doc has an example plugin to trigger the reload like before https://vite.dev/guide/migration.html#advanced
|
Yeah I think this is expected, though I didn't know that it's also affecting our recommended SSR setup which SSR modules now appear to not have HMR working. We may need to update our docs to re-enable that, or if this leads to needing a new API 🤔 |
Got it @hi-ogawa, this works and unblocks me! @bluwy - In this case, is it really HMR when it's an SSR only module, doesn't it refresh the entire page? Thank you both! |
Yeah perhaps HMR isn't the right term here 😅 But updates not appearing on the screen is a bit problematic even if it's a full page reload. With the current setup, I don't know if it's possible or makes sense to make the updates fine-grained.
Maybe it should be "app reload" or "environment reload". It's causing a "full page reload" on the server-side modules, but there's no page on the server-side. It was likely borrowed when we refactor the HMR for the environment api. |
That makes sense, yeah I like "app/environment reload" I think that would be more clear. Thanks for looking into this, let me know if I can help somehow. |
Describe the bug
Using the
create-vite-extra
- Vanilla SSR template, when editingsrc/entry-server.ts
and saving, it no longer triggers a page reload. Editing and savingentry-client
works as expected.When using v5.4.9 this does not occur.
Reproduction
https://github.com/bluwy/create-vite-extra/tree/master/template-ssr-vanilla
Steps to reproduce
edit
src/entry-server.ts
and save, I'm thinking this should trigger refreshSystem Info
Used Package Manager
npm
Logs
No response
Validations
The text was updated successfully, but these errors were encountered: