Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ssr): remove link to Discord channel #19202

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

jahredhope
Copy link
Contributor

@jahredhope jahredhope commented Jan 14, 2025

Description

Remove link from an old archived SSR channel, the channel has been combined into a general collaboration channel. The link was added when there was a particular need to raise SSR related questions. This is no-longer the case.

As per patak's comment the channels have been combined into a central collaborate channel.

Hey! We're simplifying a bit the channels structure. Let's use the ⁠collaborate channel from now on. With threads we can all hangout together there and mix and match the topics we used to discuss here 👋
The history of this channel will still be searchable.

As per [patak's comment](https://discord.com/channels/804011606160703521/804061937029218334/1201538888439713842)

> Hey! We're simplifying a bit the channels structure. Let's use the ⁠collaborate channel from now on. With threads we can all hangout together there and mix and match the topics we used to discuss here 👋 
The history of this channel will still be searchable.

The channels have been combined into a central collaborate channel
@jahredhope jahredhope changed the title Update SSR link to combined Discord channel docs: Update SSR link to combined Discord channel Jan 14, 2025
@jahredhope jahredhope changed the title docs: Update SSR link to combined Discord channel docs(ssr): Update link to combined Discord channel Jan 14, 2025
@jahredhope jahredhope changed the title docs(ssr): Update link to combined Discord channel docs(ssr): update link to combined Discord channel Jan 14, 2025
@patak-dev
Copy link
Member

I think we should remove this tip. It was created at a point where there were a lot of questions about SSR, but the tip applies to everything in Vite, not only SSR. Would you modify the PR to remove the whole block @jahredhope?

@jahredhope
Copy link
Contributor Author

Will do @patak-dev

@jahredhope jahredhope changed the title docs(ssr): update link to combined Discord channel docs(ssr): Remove link to Discord channel Jan 14, 2025
@jahredhope jahredhope changed the title docs(ssr): Remove link to Discord channel docs(ssr): remove link to Discord channel Jan 14, 2025
@jahredhope
Copy link
Contributor Author

I've updated the title, description and content of this change, but I haven't tested the change yet.

@patak-dev patak-dev merged commit 0802662 into vitejs:main Jan 14, 2025
13 of 14 checks passed
@jahredhope jahredhope deleted the patch-1 branch January 14, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants