Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: upgrade to tailwind v4 #19320

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test: upgrade to tailwind v4 #19320

wants to merge 5 commits into from
+428 −80

Conversation

sapphi-red
Copy link
Member

Description

close #19299

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Jan 30, 2025
sapphi-red
sapphi-red commented Jan 30, 2025
View reviewed changes
playground/test-utils.ts
@@ -75,7 +75,7 @@ function componentToHex(c: number): string {
return hex.length === 1 ? '0' + hex : hex
}

function rgbToHex(rgb: string): string {
function rgbToHex(rgb: string): string | undefined {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When oklch(...) is passed, previously #000000 was returned.

@patak-dev patak-dev requested a review from ArnaudBarre January 30, 2025 17:34
ArnaudBarre
ArnaudBarre reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@ArnaudBarre ArnaudBarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this and reporting the issue to Tailwind!
Is there still a Tailwind 3 playground in the test suite? I think we should keep one for at least 6 months, it would be bad to break some old HMR path that are kindof tailwind 3 specific

@birkskyum
Copy link
Contributor

Would it be possible to also test the tailwind vite plugin?

It's being push as the default for vite usage
https://tailwindcss.com/docs/installation/using-vite

@sapphi-red
Copy link
Member Author

Is there still a Tailwind 3 playground in the test suite? I think we should keep one for at least 6 months, it would be bad to break some old HMR path that are kindof tailwind 3 specific

I upgraded all the tests to use tailwind v4, so there weren't any. I added back the old playground as "tailwind-v3" now. The content is duplicated with "tailwind" playground. I can't think of an easy way to dedupe this. It will be removed in half a year anyways, so it's probably ok.

@sapphi-red
Copy link
Member Author

Would it be possible to also test the tailwind vite plugin?

It does use the vite plugin except for the one that is blocked by tailwind's bug and the one that requires postcss to be used.

@ArnaudBarre
Copy link
Member

Yeah dedupe is totally fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnaudBarre ArnaudBarre ArnaudBarre left review comments

@Sec32fun32 Sec32fun32 Sec32fun32 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sapphi-red @birkskyum @ArnaudBarre @Sec32fun32