Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin-web] Upgrade to node v16.13.0 LTS #9136

Merged
merged 8 commits into from
Nov 4, 2021
Merged

[vtadmin-web] Upgrade to node v16.13.0 LTS #9136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9847dff
Update node/npm version in package.json
doeg Nov 3, 2021
de6c7c7
Allow npm to auto-update package-lock.json
doeg Nov 3, 2021
d06191f
Exchange node-sass for sass
doeg Nov 3, 2021
0c9403b
Update README with node/npm versions
doeg Nov 3, 2021
fe5318f
Upgrade react-scripts from v4.0.1 to v4.0.3
doeg Nov 3, 2021
135c0ab
Fix sass warnings about division operator; use math.div instead
doeg Nov 3, 2021
4c12aa0
Configure .stylelintrc to ignore @uses directive
doeg Nov 3, 2021
c85ea61
Update node version in GitHub CI workflows
doeg Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- uses: actions/setup-node@v2
with:
# node-version should match package.json
node-version: '14.15'
node-version: '16.13.0'

- name: Install dependencies
run: npm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- uses: actions/setup-node@v2
with:
# node-version should match package.json
node-version: '14.15'
node-version: '16.13.0'

- name: Install dependencies
run: npm install
Expand Down
5 changes: 4 additions & 1 deletion web/vtadmin/.stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,8 @@
"extends": [
"stylelint-config-standard",
"stylelint-config-prettier"
]
],
"rules": {
"at-rule-no-unknown": null
}
}
5 changes: 5 additions & 0 deletions web/vtadmin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# VTAdmin

## Prerequisites

- [node](https://nodejs.org) >= 16.13.0 LTS
- npm >= 8.1.0 (comes with node)

## Available scripts

Scripts for common and not-so-common tasks. These are always run from the `vitess/web/vtadmin` directory (although some of them have counterparts in `vitess/Makefile`):
Expand Down
Loading