Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interferes with some websites #35

Open
tarranjones opened this issue Feb 3, 2016 · 7 comments
Open

interferes with some websites #35

tarranjones opened this issue Feb 3, 2016 · 7 comments

Comments

@tarranjones
Copy link

I've had a couple of issues when "Access-Control-Expose-Headers" is enabled and were immediately fixed when disabled.

@tarranjones
Copy link
Author

attempting to login to github

@tarranjones
Copy link
Author

Playing videos on youtube

@aziz
Copy link

aziz commented Feb 5, 2016

That's why I suggest to be able to disable or enable it based on domain, just like how Ad blockers behave.

@tarranjones
Copy link
Author

Cant you use localStorage to remember whether it was enabled or not.
Every now and then i use chrome and its enabled again. not sure why?

@yaring
Copy link

yaring commented Jun 8, 2016

@aziz sounds great!
You literally cannot use the chrome when having CORS, we definitely needs white list domain based to turn on CORS.

@ondratra
Copy link

ondratra commented Aug 27, 2016

The problem with websites is that extension thrashes rest of headers(reasons are not clear to me). Lines in background.js:

return {requestHeaders: details.requestHeaders}; ... return {responseHeaders: details.responseHeaders};
should be simply return requestHeaders; & return responseHeaders; (I checked Youtube after this modification and it worked).
@vitvad is there any reason for this?

@ondratra
Copy link

Nevermind my previous comment. It actually breaks the mechanism and "working Youtube" is probably just side effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants