Skip to content

Commit 0b443b6

Browse files
committed
Remove hardly visible dimension axis guides between animation steps.
1 parent 4baccf9 commit 0b443b6

File tree

3 files changed

+67
-67
lines changed

3 files changed

+67
-67
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### Fixed
66

7+
- Remove hardly visible dimension axis guides between animation steps.
78
- Do not calculate disabled markers to the color normalization.
89
- More precise TS type for transform matrix in event handlers.
910
- Add missing canvas change function in htmlcanvas plugin.

src/chart/generator/guides.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ bool GuidesByAxis::operator==(const GuidesByAxis &other) const
3333
Guides::Guides(const Options &options)
3434
{
3535
auto isCircle = options.geometry.get() == ShapeType::circle;
36-
auto isLine = options.geometry.get() == ShapeType::line;
3736
auto isHorizontal = options.isHorizontal();
3837
const auto &channelX = options.getChannels().at(ChannelId::x);
3938
const auto &channelY = options.getChannels().at(ChannelId::y);
@@ -53,8 +52,8 @@ Guides::Guides(const Options &options)
5352
y.markerGuides = yOpt.markerGuides.getValue(
5453
isCircle && xIsMeasure && !isPolar);
5554

56-
x.axisGuides = xOpt.guides.getValue(isLine && xIsMeasure);
57-
y.axisGuides = yOpt.guides.getValue(isLine && yIsMeasure);
55+
x.axisGuides = xOpt.guides.getValue(false);
56+
y.axisGuides = yOpt.guides.getValue(false);
5857

5958
x.interlacings = xOpt.interlacing.getValue(
6059
xIsMeasure && !isPolar && (!isHorizontal || !yIsMeasure));

0 commit comments

Comments
 (0)