Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

Prevent menu to show up after fire dragStart. #321

Closed
robert8888 opened this issue Mar 30, 2020 · 5 comments
Closed

Prevent menu to show up after fire dragStart. #321

robert8888 opened this issue Mar 30, 2020 · 5 comments

Comments

@robert8888
Copy link

Actual Behavior

When dragStart is fired menu shows up after value setted to holdToDisplay. Yes you can set holdToDisplay on -1 but still is not desire behavior.

Best

@vkbansal
Copy link
Owner

This is intended behaviour. Changing this will make it stop working on touch screen devices.

@stale
Copy link

stale bot commented May 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 30, 2020
@robert8888
Copy link
Author

Ok. I get this point of view, but still i suppose that you can catch drag start / drag end on the root (eg. body) element (it is bubbling in most case) and then don't show menu during dragging.

Best.

@stale stale bot removed the wontfix label Jun 2, 2020
@vkbansal
Copy link
Owner

vkbansal commented Jun 3, 2020

I'm not too familiar with how things work on touch devices. Can you share a code sample of what you are proposing? Even better if you could provide a PR.

@vkbansal
Copy link
Owner

closing issue see #339

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants