Unable to use the plugin on DX12 after 0.37 update

[mnmaita]

I'm currently upgrading a project to Bevy 0.17 and I'm using the WorldInspectorPlugin from bevy-inspector-egui in it, which requires the EguiPlugin from bevy_egui. I'm getting the following error when as soon as I run the app:

Internal error in ShaderStages(FRAGMENT) shader: HLSL: Unimplemented("push-constant 'offset' has non-struct type; tracked by: https://github.com/gfx-rs/wgpu/issues/5683")

It looks like the problem lies on this shader (the push_constant var):

bevy_egui/src/render/egui.wgsl

Line 23 in 2bf1934

var<push_constant> offset: u32;

wgpu devs acknowledge that this is a bug on their end while using DX12 as backend. I wonder if there are any workarounds for this to be applied to this shader code in the meantime. It works well when using Vulkan but our app performance tanked very hard on Windows machines after some of the recent upgrades (and I'm still trying to figure out which update caused these big perf regressions).

[mnmaita]

For now, my quick and dirty workaround is the following (so other people facing this issue can easily migrate):

I'm checking the WGPU_BACKEND env var via std::env::var() and if it is "dx12" I simply skip adding the inspection/egui plugins.

[vladbat00]

Hi! Setting EguiPlugin::bindless_mode_array_size to None should disable the bindless texture support, for which the push constant is used

[vladbat00]

It works well when using Vulkan but our app performance tanked very hard on Windows machines after some of the recent upgrades (and I'm still trying to figure out which update caused these big perf regressions)

Do you suspect bevy_egui causing those or it might be something else used in your app?

[mnmaita]

I'll try that, thanks a lot!

As for the performance issues I'm sure it is completely unrelated to the egui plugin. By not adding the plugin to the app I still have issues. I have a feeling that it might be a NVIDIA driver/device issue when using Vulkan, as I've tried older versions of our project and these performance issues won't go away. I might try downgrading my drivers and test when I have some time.