Skip to content

Commit 8f7def1

Browse files
authored
Merge pull request #35 from dlautz314/master
converted HTTP network calls to more secure HTTPS network calls.
2 parents 54a357f + 456d1bf commit 8f7def1

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

qgeotilefetchergooglemaps.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ QGeoTileFetcherGooglemaps::QGeoTileFetcherGooglemaps(const QVariantMap &paramete
3636
m_apiKey = parameters.value(QStringLiteral("googlemaps.apikey")).toString();
3737
m_signature = parameters.value(QStringLiteral("googlemaps.maps.signature")).toString();
3838
m_client = parameters.value(QStringLiteral("googlemaps.maps.client")).toString();
39-
m_baseUri = QStringLiteral("http://maps.googleapis.com/maps/api/staticmap");
39+
m_baseUri = QStringLiteral("https://maps.googleapis.com/maps/api/staticmap");
4040
if (parameters.contains(QStringLiteral("googlemaps.useragent")))
4141
_userAgent = parameters.value(QStringLiteral("googlemaps.useragent")).toString().toLatin1();
4242
else
@@ -122,31 +122,31 @@ QString QGeoTileFetcherGooglemaps::_getURL(int type, int x, int y, int zoom)
122122
QString sec1 = ""; // after &x=...
123123
QString sec2 = ""; // after &zoom=...
124124
_getSecGoogleWords(x, y, sec1, sec2);
125-
return QString("http://mt.google.com/vt/lyrs=m&hl=%1&x=%2%3&y=%4&z=%5&s=%6&scale=%7").arg(_language).arg(x).arg(sec1).arg(y).arg(zoom).arg(sec2).arg(_scale);
125+
return QString("https://mt.google.com/vt/lyrs=m&hl=%1&x=%2%3&y=%4&z=%5&s=%6&scale=%7").arg(_language).arg(x).arg(sec1).arg(y).arg(zoom).arg(sec2).arg(_scale);
126126
}
127127
break;
128128
case 2: //Satallite Map
129129
{
130130
QString sec1 = ""; // after &x=...
131131
QString sec2 = ""; // after &zoom=...
132132
_getSecGoogleWords(x, y, sec1, sec2);
133-
return QString("http://mt.google.com/vt/lyrs=s&hl=%1&x=%2%3&y=%4&z=%5&s=%6&scale=%7").arg(_language).arg(x).arg(sec1).arg(y).arg(zoom).arg(sec2).arg(_scale);
133+
return QString("https://mt.google.com/vt/lyrs=s&hl=%1&x=%2%3&y=%4&z=%5&s=%6&scale=%7").arg(_language).arg(x).arg(sec1).arg(y).arg(zoom).arg(sec2).arg(_scale);
134134
}
135135
break;
136136
case 3: //Terrain Map
137137
{
138138
QString sec1 = ""; // after &x=...
139139
QString sec2 = ""; // after &zoom=...
140140
_getSecGoogleWords(x, y, sec1, sec2);
141-
return QString("http://mt.google.com/vt/lyrs=p&hl=%1&x=%2%3&y=%4&z=%5&s=%6&scale=%7").arg(_language).arg(x).arg(sec1).arg(y).arg(zoom).arg(sec2).arg(_scale);
141+
return QString("https://mt.google.com/vt/lyrs=p&hl=%1&x=%2%3&y=%4&z=%5&s=%6&scale=%7").arg(_language).arg(x).arg(sec1).arg(y).arg(zoom).arg(sec2).arg(_scale);
142142
}
143143
break;
144144
case 4: //Hybrid Map
145145
{
146146
QString sec1 = ""; // after &x=...
147147
QString sec2 = ""; // after &zoom=...
148148
_getSecGoogleWords(x, y, sec1, sec2);
149-
return QString("http://mt.google.com/vt/lyrs=y&hl=%1&x=%2%3&y=%4&z=%5&s=%6&scale=%7").arg(_language).arg(x).arg(sec1).arg(y).arg(zoom).arg(sec2).arg(_scale);
149+
return QString("https://mt.google.com/vt/lyrs=y&hl=%1&x=%2%3&y=%4&z=%5&s=%6&scale=%7").arg(_language).arg(x).arg(sec1).arg(y).arg(zoom).arg(sec2).arg(_scale);
150150
}
151151
break;
152152
}
@@ -198,7 +198,7 @@ void QGeoTileFetcherGooglemaps::_tryCorrectGoogleVersions(QNetworkAccessManager*
198198
conf.setPeerVerifyMode(QSslSocket::VerifyNone);
199199
qheader.setSslConfiguration(conf);
200200
#endif
201-
QString url = "http://maps.google.com/maps/api/js?v=3.2&sensor=false";
201+
QString url = "https://maps.google.com/maps/api/js?v=3.2&sensor=false";
202202
qheader.setUrl(QUrl(url));
203203
qheader.setRawHeader("User-Agent", _userAgent);
204204
_googleReply = networkManager->get(qheader);

qplacemanagerenginegooglemaps.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
namespace
1818
{
19-
QString SpecialPhrasesBaseUrl = QStringLiteral("http://wiki.openstreetmap.org/wiki/Special:Export/Nominatim/Special_Phrases/");
19+
QString SpecialPhrasesBaseUrl = QStringLiteral("https://wiki.openstreetmap.org/wiki/Special:Export/Nominatim/Special_Phrases/");
2020

2121
QString nameForTagKey(const QString &tagKey)
2222
{

0 commit comments

Comments
 (0)