Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Outdated binaries when re-building vLLM from source #5456

Closed
DarkLight1337 opened this issue Jun 12, 2024 · 2 comments · Fixed by #5462
Closed

[Bug]: Outdated binaries when re-building vLLM from source #5456

DarkLight1337 opened this issue Jun 12, 2024 · 2 comments · Fixed by #5462
Labels
bug Something isn't working

Comments

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jun 12, 2024

🐛 Describe the bug

After upgrading vLLM (e.g. syncing a fork with latest main branch), re-building from source fails to clear/overwrite the existing compiled binaries, resulting in errors such as

AttributeError: '_OpNamespace' '_C' object has no attribute ...

Workaround

Installing from a fresh clone of vLLM fixes this error.

Nevertheless, it would be ideal to automatically remove/update outdated binaries when re-building vLLM.

Related issues

@DarkLight1337 DarkLight1337 added the bug Something isn't working label Jun 12, 2024
@DarkLight1337 DarkLight1337 changed the title [Bug]: [Bug]: Outdated binaries when re-building vLLM from source Jun 12, 2024
@mgoin
Copy link
Collaborator

mgoin commented Jun 12, 2024

This can be manually addressed by clearing any existing built libraries in vllm with rm vllm/_C* vllm/_moe_C.*

@youkaichao
Copy link
Member

it would be ideal to automatically remove/update outdated binaries when re-building vLLM

Users might feel unhappy when we silently delete their files.

I added some hints for users, and users can follow the instruction to do the cleanup.

Let me know if you like this idea.

@Trangle
Copy link

Trangle commented Jun 13, 2024

It worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants